smengcl commented on code in PR #8587:
URL: https://github.com/apache/ozone/pull/8587#discussion_r2373384009
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -57,6 +58,7 @@ public final class OmKeyInfo extends WithParentObjectId
private static final Codec<OmKeyInfo> CODEC_TRUE = newCodec(true);
private static final Codec<OmKeyInfo> CODEC_FALSE = newCodec(false);
+ private static final String COMMITTED_KEY_DELETED_FLAG =
"COMMITTED_KEY_DELETED";
Review Comment:
This would be persisted to every single key deleted? In that case we should
reduce the number of bytes this string occupies. e.g.
```suggestion
private static final String COMMITTED_KEY_DELETED_FLAG = "COMKEYDEL";
```
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -57,6 +58,7 @@ public final class OmKeyInfo extends WithParentObjectId
private static final Codec<OmKeyInfo> CODEC_TRUE = newCodec(true);
private static final Codec<OmKeyInfo> CODEC_FALSE = newCodec(false);
+ private static final String COMMITTED_KEY_DELETED_FLAG =
"COMMITTED_KEY_DELETED";
Review Comment:
This metadata would be added for every single key deleted? In that case we
should reduce the number of bytes this string occupies. e.g.
```suggestion
private static final String COMMITTED_KEY_DELETED_FLAG = "COMKEYDEL";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
