swamirishi commented on code in PR #9140:
URL: https://github.com/apache/ozone/pull/9140#discussion_r2461333325


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java:
##########
@@ -75,6 +93,7 @@ public void computeAndSetChecksum(Yaml yaml, 
OmSnapshotLocalData data) throws IO
       }
     };
     this.versionNodeMap = new HashMap<>();

Review Comment:
   why so? We are always acquiring a readLock or write lock before accessing 
the map. We cannot access his in a thread safe way anyhow without acquiring lock



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to