smengcl commented on code in PR #9140:
URL: https://github.com/apache/ozone/pull/9140#discussion_r2462266758
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java:
##########
@@ -75,6 +93,7 @@ public void computeAndSetChecksum(Yaml yaml,
OmSnapshotLocalData data) throws IO
}
};
this.versionNodeMap = new HashMap<>();
Review Comment:
locking is good but lock alone may not be sufficient.
see Java memory model. related: https://stackoverflow.com/a/15794355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
