xichen01 commented on code in PR #9185:
URL: https://github.com/apache/ozone/pull/9185#discussion_r2463935779
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfig.java:
##########
@@ -138,6 +139,15 @@ public class ScmConfig extends ReconfigurableConfig {
)
private int transactionToDNsCommitMapLimit = 5000000;
+ @Config(key = "hdds.scm.block.deleting.service.scheduling.mode",
+ defaultValue = "FIXED_RATE",
+ type = ConfigType.STRING,
+ tags = { ConfigTag.SCM, ConfigTag.DELETION },
+ description = "Scheduling mode for the block deleting service. For
detailed, " +
+ "see org.apache.hadoop.hdds.utils.SchedulingMode"
+ )
+ private String blockDeletingServiceSchedulingMode =
SchedulingMode.FIXED_RATE.name();
Review Comment:
`BackgroundService` interval and mode are two independent parameters, just
like scheduleAtFixedRate and scheduleAtFixedRate of `ScheduledExecutorService`
> I wouldn't want to introduce redundant configs which can confuse a user
based on some convoluted logic.
In most cases, the default configuration is sufficient for users and users
do not need to understand every configuration. When users have special needs,
they can adjust specific parameters to meet their needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
