sarvekshayr commented on PR #9216:
URL: https://github.com/apache/ozone/pull/9216#issuecomment-3471493973
Tested the fix manually.
- Before the fix: When the DB was not named `om.db`, the tool returned a
null report, which was unclear and did not indicate the actual issue.
```
$ bin/ozone repair om fso-tree --db=/Users/sarvekshayr/OMDB/om.db --dry-run
[dry run] No running OM service detected. Proceeding with repair.
[dry run] Creating database with reachable and unreachable tables at
/Users/sarvekshayr/OMDB/temp.db
[dry run] Processing volume: /benchmarking
[dry run] Processing bucket: benchmarking/e043069
...
```
```
$ bin/ozone repair om fso-tree
--db=/Users/sarvekshayr/OMDB/copy/om-db-backup --dry-run
[dry run] No running OM service detected. Proceeding with repair.
[dry run] Creating database with reachable and unreachable tables at
/Users/sarvekshayr/OMDB/copy/temp.db
[dry run]
Reachable:
Directories: 0
Files: 0
Bytes: 0
Unreachable (Pending to delete):
Directories: 0
Files: 0
Bytes: 0
Unreferenced (Orphaned):
Directories: 0
Files: 0
Bytes: 0
```
- After the fix: The tool now accepts any DB name, and the report is
generated correctly with no ambiguity.
```
$ bin/ozone repair om fso-tree --db=/Users/sarvekshayr/OMDB/om.db --dry-run
[dry run] No running OM service detected. Proceeding with repair.
[dry run] Creating database with reachable and unreachable tables at
/Users/sarvekshayr/OMDB/temp.db
[dry run] Processing volume: /benchmarking
[dry run] Processing bucket: benchmarking/e043069
...
```
```
$ bin/ozone repair om fso-tree
--db=/Users/sarvekshayr/OMDB/copy/om-db-backup --dry-run
[dry run] No running OM service detected. Proceeding with repair.
[dry run] Creating database with reachable and unreachable tables at
/Users/sarvekshayr/OMDB/copy/temp.db
[dry run] Processing volume: /benchmarking
[dry run] Processing bucket: benchmarking/e043069
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
