sarvekshayr commented on code in PR #9216:
URL: https://github.com/apache/ozone/pull/9216#discussion_r2480292991
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/repair/om/TestFSORepairTool.java:
##########
@@ -378,6 +390,30 @@ private int execute(boolean dryRun, String... args) {
.execute(() -> cmd.execute(argList.toArray(new String[0])));
}
+ @Order(2)
+ @Test
+ public void testAlternateOmDbDirNameDryRun() throws Exception {
Review Comment:
This test currently passes with or without the fix because the previous
implementation always expected `om.db`. Since `om.db` happens to exist in the
same directory as `om-db-backup`, the tool silently picks up `om.db` and
generates a valid report instead of returning a null report, which hides the
bug. You can verify this behaviour once.
To properly validate the fix, please update the test so that `om.db` resides
in a different path than `om-db-backup`.
Before the fix: the test should produce a null report.
After the fix: the test should correctly generate the report for the
provided DB path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
