sodonnel commented on PR #9305: URL: https://github.com/apache/ozone/pull/9305#issuecomment-3559150843
Code change looks fine, I just have a question. OMVolumeArgs, seems to be a kind of persistent object that describes a volume in OM. I cannot see an OMVolumeInfo class. The only place the reference count seems to get incremented and decremented is in OmTenantCreateRequest, which I guess is a rare operation, so performance is likely no concern here. Are we planning to make similar changes to bucket objects too? For example OmBucketInfo, which has `incrUsedBytes` etc. I would be a little concerned about GC churn for a highly mutated object like OmBucketInfo where the original object and the builder would be disposed of for each mutation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
