adoroszlai commented on PR #9305: URL: https://github.com/apache/ozone/pull/9305#issuecomment-3562258021
> Are we planning to make similar changes to bucket objects too? Yes. > For example OmBucketInfo, which has `incrUsedBytes` etc. I would be a little concerned about GC churn for a highly mutated object like OmBucketInfo where the original object and the builder would be disposed of for each mutation. This already exists, because OM creates a copy of `OmBucketInfo` for the response. Example: https://github.com/apache/ozone/blob/d7e68784840083aca9e6c1683402b4cf5e5c64f7/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java#L406-L408 By making `OmBucketInfo` immutable this copy operation can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
