swamirishi commented on code in PR #9354:
URL: https://github.com/apache/ozone/pull/9354#discussion_r2555822870
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/WithObjectID.java:
##########
@@ -64,6 +64,44 @@ public final long getUpdateID() {
return updateID;
}
+ /**
+ * Asserts that the new updateID is greater than the current updateID.
+ * @param newValue - new updateID value
+ */
+ public final void assertMonotonicUpdateID(long newValue) {
Review Comment:
Why have a separate method call everytime one needs to set updateID? If some
newer api doesn't call this method and then this check would never run. This
change would make future changes susceptible to bugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
