adoroszlai commented on PR #9354: URL: https://github.com/apache/ozone/pull/9354#issuecomment-3570278972
Thanks @echonesis for the patch. This makes `setUpdateID` error-prone, because it puts the responsibility on the caller to make the additional `assertMonotonicUpdateID` call. (Arguably, this is already the case by having two separate methods `setUpdateID` and `withUpdateID`.) Please see #9356 for avoiding that problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
