adoroszlai commented on code in PR #9356:
URL: https://github.com/apache/ozone/pull/9356#discussion_r2556201557
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartKeyInfo.java:
##########
@@ -293,18 +293,18 @@ public Builder setUpdateID(long id) {
return this;
}
- @Override
- public Builder withUpdateID(long newValue) {
- super.withUpdateID(newValue);
- return this;
- }
-
public Builder setParentID(long parentObjId) {
this.parentID = parentObjId;
return this;
}
public OmMultipartKeyInfo build() {
+ validate();
Review Comment:
> Instead of each build method calling validate we can call super.build()
and that could call validate() method. The changes wouldn't be this big.
`super.build()` returns `WithObjectID`, not the specific subtype.
> I feel this would be error prone again for newer implementations which
could miss this.
There are much fewer `Builder` subclasses than users of `Builder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
