swamirishi commented on code in PR #9356:
URL: https://github.com/apache/ozone/pull/9356#discussion_r2556269302
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/WithObjectID.java:
##########
@@ -70,18 +71,24 @@ public String getObjectInfo() {
}
/** Builder for {@link WithObjectID}. */
- public static class Builder extends WithMetadata.Builder {
+ public abstract static class Builder extends WithMetadata.Builder {
+ private final long initialObjectID;
+ private final long initialUpdateID;
private long objectID;
private long updateID;
protected Builder() {
super();
+ initialObjectID = 0;
+ initialUpdateID = OzoneConsts.DEFAULT_OM_UPDATE_ID;
}
protected Builder(WithObjectID obj) {
super(obj);
Review Comment:
The buildObject would be the previous build() method implementation or the
current buildMaybeInvalid() and actual build() object will never get overridden
maybe we can make it final
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartKeyInfo.java:
##########
@@ -293,18 +293,18 @@ public Builder setUpdateID(long id) {
return this;
}
- @Override
- public Builder withUpdateID(long newValue) {
- super.withUpdateID(newValue);
- return this;
- }
-
public Builder setParentID(long parentObjId) {
this.parentID = parentObjId;
return this;
}
public OmMultipartKeyInfo build() {
+ validate();
Review Comment:
The buildObject would be the previous build() method implementation or the
current buildMaybeInvalid() and actual build() object will never get overridden
maybe we can make it final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
