sumitagrawl commented on code in PR #9351:
URL: https://github.com/apache/ozone/pull/9351#discussion_r2581618360


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/dn/volume/TestDatanodeHddsVolumeFailureDetection.java:
##########
@@ -156,7 +156,8 @@ void corruptContainerFile(boolean schemaV3) throws 
Exception {
         // refer to HddsVolume.check()
         DatanodeTestUtils.simulateBadVolume(vol0);
 
-        // close container to trigger checkVolumeAsync
+        // close container to trigger checkVolumeAsync after 2 seconds as 
minGap to check
+        Thread.sleep(2000);

Review Comment:
   assertThrows(IOException.class, c1::close);  <-- close trigger 
**IOException** which internally call onFailure() which further results in 
**trigger for volume check**.
   But this volume check is **ignored** as **diskCheckMinGap** is 2 second and 
this trigger is before 2 second time. So numOfFailedVolumes remain "0"
   
   Timer waitFor() gets timeout causing failure of testcase since no further 
event to trigger volume check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to