sodonnel commented on code in PR #9351:
URL: https://github.com/apache/ozone/pull/9351#discussion_r2569569373


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/dn/volume/TestDatanodeHddsVolumeFailureDetection.java:
##########
@@ -156,7 +156,8 @@ void corruptContainerFile(boolean schemaV3) throws 
Exception {
         // refer to HddsVolume.check()
         DatanodeTestUtils.simulateBadVolume(vol0);
 
-        // close container to trigger checkVolumeAsync
+        // close container to trigger checkVolumeAsync after 2 seconds as 
minGap to check
+        Thread.sleep(2000);

Review Comment:
   I don't understand why any wait is needed here. The 
`injectContainerMetaDirFailure` and `simulateBadVolume` immediately set the 
permissions on the folder to be non-writable, so the closing of the container 
should fail immediately. There isn't anything asynchronous going on here that I 
can see.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to