adoroszlai commented on PR #9439: URL: https://github.com/apache/ozone/pull/9439#issuecomment-3618126920
> Once concern is that the logs are emitted too frequently This method is called for several reasons, one of them is collecting metrics, which happens every 30 seconds according to #9418 (though I guess it depends on Prometheus and other settings). My other concern is that this provides little information, only datanode ID/address and requested space. Please see `AvailableSpaceFilter` for a better approach: upon checking each volume, it keeps track of ones that are full, which are then printed by `toString()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
