adoroszlai commented on code in PR #9439:
URL: https://github.com/apache/ozone/pull/9439#discussion_r2603157084
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java:
##########
@@ -291,55 +296,81 @@ public List<DatanodeDetails>
filterNodesWithSpace(List<DatanodeDetails> nodes,
}
/**
- * Returns true if this node has enough space to meet our requirement.
+ * Check if a datanode has sufficient space and return detailed result.
*
* @param datanodeDetails DatanodeDetails
- * @return true if we have enough space.
+ * @param metadataSizeRequired metadata size required
+ * @param dataSizeRequired data size required
+ * @param conf configuration
+ * @return SCMDatanodeSpaceCheckResult with detailed volume information
*/
- public static boolean hasEnoughSpace(DatanodeDetails datanodeDetails,
- long metadataSizeRequired,
- long dataSizeRequired,
- ConfigurationSource conf) {
+ public static SCMDatanodeSpaceCheckResult checkSpace(DatanodeDetails
datanodeDetails,
+ long
metadataSizeRequired,
+ long dataSizeRequired,
+ ConfigurationSource
conf) {
Review Comment:
nit: Please do not format method signature like this. Whenever visibility /
return type / method name / other modifiers are changed, we would have to
reindent all parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
