Gargi-jais11 commented on code in PR #9460:
URL: https://github.com/apache/ozone/pull/9460#discussion_r2597657478
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/fs/DedicatedDiskSpaceUsageFactory.java:
##########
@@ -61,7 +61,7 @@ public static class Conf {
private static final String REFRESH_PERIOD = "refresh.period";
@Config(
- key = REFRESH_PERIOD,
+ key = "hdds.datanode.df.refresh.period",
Review Comment:
Okay @adoroszlai . Thanks for clarifying this.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/fs/SpaceUsageCheckFactory.java:
##########
@@ -131,7 +131,7 @@ class Conf {
private static final String CLASSNAME_KEY = "classname";
@Config(
- key = CLASSNAME_KEY,
+ key = "hdds.datanode.du.factory.classname",
Review Comment:
Please reuse the existing parmaters:
```suggestion
key = CONFIG_PREFIX + "." + CLASSNAME_KEY,
```
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java:
##########
@@ -189,7 +189,7 @@ public static final class ReplicationConfig {
* The maximum number of replication commands a single datanode can execute
* simultaneously.
*/
- @Config(key = STREAMS_LIMIT_KEY,
+ @Config(key = "hdds.datanode.replication.streams.limit",
Review Comment:
You can reuse `REPLICATION_STREAMS_LIMIT_KEY`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
