adoroszlai commented on code in PR #9460:
URL: https://github.com/apache/ozone/pull/9460#discussion_r2597817729
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMClientConfig.java:
##########
@@ -31,13 +31,13 @@
*/
@ConfigGroup(prefix = "hdds.scmclient")
public class SCMClientConfig {
- public static final String SCM_CLIENT_RPC_TIME_OUT = "rpc.timeout";
+ public static final String SCM_CLIENT_RPC_TIME_OUT =
"hdds.scmclient.rpc.timeout";
public static final String SCM_CLIENT_FAILOVER_MAX_RETRY =
- "failover.max.retry";
+ "hdds.scmclient.failover.max.retry";
public static final String SCM_CLIENT_MAX_RETRY_TIMEOUT =
- "max.retry.timeout";
+ "hdds.scmclient.max.retry.timeout";
public static final String SCM_CLIENT_RETRY_INTERVAL =
- "failover.retry.interval";
+ "hdds.scmclient.failover.retry.interval";
Review Comment:
Please inline these constants.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/conf/OMClientConfig.java:
##########
@@ -32,9 +32,9 @@
@ConfigGroup(prefix = "ozone.om.client")
public class OMClientConfig {
- public static final String OM_CLIENT_RPC_TIME_OUT = "rpc.timeout";
+ public static final String OM_CLIENT_RPC_TIME_OUT =
"ozone.om.client.rpc.timeout";
public static final String OM_TRASH_EMPTIER_CORE_POOL_SIZE
- = "trash.core.pool.size";
+ = "ozone.om.client.trash.core.pool.size";
Review Comment:
Please inline these constants (use string value directly in `key`). They
are not used elsewhere.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java:
##########
@@ -170,7 +170,7 @@ public static final class ReplicationConfig {
public static final String PREFIX = "hdds.datanode.replication";
public static final String STREAMS_LIMIT_KEY = "streams.limit";
- public static final String QUEUE_LIMIT = "queue.limit";
+ public static final String QUEUE_LIMIT =
"hdds.datanode.replication.queue.limit";
Review Comment:
Please inline this constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
