chungen0126 commented on code in PR #9466:
URL: https://github.com/apache/ozone/pull/9466#discussion_r2604160556
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java:
##########
@@ -159,6 +165,11 @@ public static boolean checkAclRights(List<OzoneAcl> acls,
*/
public static boolean inheritDefaultAcls(List<OzoneAcl> acls,
List<OzoneAcl> parentAcls, OzoneAcl.AclScope scope) {
+ return inheritDefaultAcls(acls::add, parentAcls, scope);
Review Comment:
Was the move away from `addAcl` intentional? `addAcl` handled permission
merging, whereas passing `acls::add` here will simply append duplicates. It
might be safer to stick with the addAcl behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
