priyeshkaratha commented on code in PR #9464:
URL: https://github.com/apache/ozone/pull/9464#discussion_r2606911260
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -340,6 +342,25 @@ void reportDatanode(DatanodeDetails dn) throws IOException
{
nodeStatus.put(dn, System.currentTimeMillis());
}
+ @VisibleForTesting
Review Comment:
Please remove VisibleForTesting used as it bad design.
[HDDS-12725](https://issues.apache.org/jira/browse/HDDS-12725)
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/OneReplicaPipelineSafeModeRule.java:
##########
@@ -137,6 +146,11 @@ public synchronized int getCurrentReportedPipelineCount() {
return currentReportedPipelineCount;
}
+ @VisibleForTesting
Review Comment:
Remove annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
