aryangupta1998 commented on code in PR #9464:
URL: https://github.com/apache/ozone/pull/9464#discussion_r2608151333
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java:
##########
@@ -340,6 +342,23 @@ void reportDatanode(DatanodeDetails dn) throws IOException
{
nodeStatus.put(dn, System.currentTimeMillis());
}
Review Comment:
IIUC, to do this, I have to rewrite my test by mocking all the required
classes, which I believe may not be the best approach, as all other tests in
this class use real PipelineManagerImpl, MockNodeManager, and
SCMSafeModeManager, following the same pattern as my test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
