SaketaChalamchala commented on code in PR #9485: URL: https://github.com/apache/ozone/pull/9485#discussion_r2615496843
########## hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/IteratorType.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.utils.db; + +/** + * The iterator type. + */ +public enum IteratorType { + /** + * Neither read key nor value. + */ + NEITHER, + /** + * Read key only. + */ + KEY_ONLY, + /** + * Read value only. + */ + VALUE_ONLY, + /** + * Read both key and value. + */ + KEY_AND_VALUE; + + public boolean readKey() { + return (this.ordinal() & KEY_ONLY.ordinal()) != 0; + } + + public boolean readValue() { + return (this.ordinal() & VALUE_ONLY.ordinal()) != 0; + } Review Comment: Thanks for the patch @swamirishi nit: set the bit mask explicitly instead of relying on the ordinal just to avoid any issues if the enum constants are reordered/added in the future. ```suggestion NEITHER(0), /** * Read key only. */ KEY_ONLY(1), /** * Read value only. */ VALUE_ONLY(2), /** * Read both key and value. */ KEY_AND_VALUE(3); public final int mask; IteratorType(int mask) { this.mask = mask; } public boolean readKey() { return (this.mask & KEY_ONLY.mask) != 0; } public boolean readValue() { return (this.mask & VALUE_ONLY.mask) != 0; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
