jojochuang commented on code in PR #9485:
URL: https://github.com/apache/ozone/pull/9485#discussion_r2615690318
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/SstFileSetReader.java:
##########
@@ -131,30 +135,30 @@ public void close() throws UncheckedIOException {
}
public ClosableIterator<String> getKeyStreamWithTombstone(String lowerBound,
String upperBound)
- throws RocksDBException {
+ throws RocksDBException, CodecException {
final MultipleSstFileIterator<String> itr = new
MultipleSstFileIterator<String>(sstFiles) {
//TODO: [SNAPSHOT] Check if default Options is enough.
private ManagedOptions options;
private ManagedSlice lowerBoundSlice;
private ManagedSlice upperBoundSlice;
@Override
- protected void init() {
+ protected void init() throws CodecException {
this.options = new ManagedOptions();
if (Objects.nonNull(lowerBound)) {
this.lowerBoundSlice = new ManagedSlice(
- StringUtils.string2Bytes(lowerBound));
+ StringCodec.get().toPersistedFormat(lowerBound));
}
if (Objects.nonNull(upperBound)) {
this.upperBoundSlice = new ManagedSlice(
- StringUtils.string2Bytes(upperBound));
+ StringCodec.get().toPersistedFormat(upperBound));
}
}
@Override
protected ClosableIterator<String> getKeyIteratorForFile(String file) {
return new ManagedRawSstFileIterator(file, options, lowerBoundSlice,
upperBoundSlice,
- keyValue -> StringUtils.bytes2String(keyValue.getKey()));
+ keyValue ->
StringCodec.get().fromPersistedFormat(keyValue.getKey()), KEY_ONLY);
Review Comment:
SstFileSetReader reads just the key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
