swamirishi commented on code in PR #9511: URL: https://github.com/apache/ozone/pull/9511#discussion_r2624975518
########## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/AbstractRDBBatchOperation.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdds.utils.db; + +import org.apache.hadoop.hdds.utils.db.RocksDatabase.ColumnFamily; + +/** + * Interface for performing batch operations on a RocksDB database. + * + * Provides methods to perform operations on a specific column family within + * a database, such as inserting or deleting a key-value pair or deleting + * a range of keys. These batch operations are designed for use in scenarios + * where multiple database modifications need to be grouped together, ensuring + * efficiency and atomicity. + * + * This interface extends {@link BatchOperation}, inheriting functionality for + * managing batch sizes and allowing cleanup of batch resources via the + * {@link #close()} method. + */ +public interface AbstractRDBBatchOperation extends BatchOperation { Review Comment: If I rename the class the code changes would be in many places making the patch big. That is why I took this approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
