swamirishi commented on code in PR #9511:
URL: https://github.com/apache/ozone/pull/9511#discussion_r2626439355
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/BatchOperation.java:
##########
@@ -17,11 +17,14 @@
package org.apache.hadoop.hdds.utils.db;
+import java.io.Closeable;
+
/**
* Class represents a batch operation, collects multiple db operation.
*/
-public interface BatchOperation extends AutoCloseable {
-
+public interface BatchOperation extends Closeable {
@Override
- void close();
+ void close() throws RocksDatabaseException;
Review Comment:
It depends on the implementation isn't it? Just because RDBBatchOperation
doesn't throw it shouldn't mean even the interface shouldn't throw.
RDBBatchOperation is an implementation which in memory only. Now if there is
some implementation which is going to spill things onto the disk then the same
won't hold true. I believe this should ideally be an IOException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
