adoroszlai commented on code in PR #8789:
URL: https://github.com/apache/ozone/pull/8789#discussion_r2626489752
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java:
##########
@@ -362,7 +362,7 @@ private void updateContainerReplica(final DatanodeDetails
datanodeDetails,
.setReplicaIndex(replicaProto.getReplicaIndex())
.setBytesUsed(replicaProto.getUsed())
.setEmpty(replicaProto.getIsEmpty())
- .setDataChecksum(replicaProto.getDataChecksum())
+ .setChecksums(ContainerChecksums.of(replicaProto.getDataChecksum(),
0L))
Review Comment:
Currently we only have data checksum, so we should not force all callers to
pass `0L` for metadata. I agree that we don't need `metadataOnly()`, but the
factory method with single data checksum value should still be added. To
reduce future changes (adding metadata checksum value), its name should be
`of()` rather than `dataOnly()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
