adoroszlai commented on code in PR #8789:
URL: https://github.com/apache/ozone/pull/8789#discussion_r2629835060


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ContainerReplicaHistory.java:
##########
@@ -84,23 +85,29 @@ public void setState(String state) {
   }
 
   public long getDataChecksum() {
-    return dataChecksum;
+    return getChecksums().getDataChecksum();
   }
 
-  public void setDataChecksum(long dataChecksum) {
-    this.dataChecksum = dataChecksum;
+  public ContainerChecksums getChecksums() {
+    return checksums;
+  }
+
+  public void setChecksums(ContainerChecksums checksums) {
+    this.checksums = checksums != null ? checksums : 
ContainerChecksums.unknown();
   }
 
   public static ContainerReplicaHistory fromProto(
       ContainerReplicaHistoryProto proto) {
     return new ContainerReplicaHistory(UUID.fromString(proto.getUuid()),
         proto.getFirstSeenTime(), proto.getLastSeenTime(), proto.getBcsId(),
-        proto.getState(), proto.getDataChecksum());
+        proto.getState(), ContainerChecksums.of(proto.getDataChecksum(), 0L));

Review Comment:
   ```suggestion
           proto.getState(), ContainerChecksums.of(proto.getDataChecksum()));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to