devmadhuu commented on PR #9472: URL: https://github.com/apache/ozone/pull/9472#issuecomment-3695402455
> > private short healthStateValue; // 2 bytes - memory efficient! > > Looks like an AI optimization, which means it has no context about real world clusters. I recently worked on a cluster with 32 million containers and 200PB+ of data running with 127GB of heap. Storing this as a short will consume 32Mil * 2B = **64MB** of space. Storing it as an enum, which is much easier for devs to work with, will consume 32Mil * 8B = **256MB** of space. (256mb - 64mb)/127gb = 0.001 > > So all this inconvenience is for a 0.1% reduction in heap usage at scale. > > I do think we should track the container health state in the container info object in memory for easier queries, but based on real world numbers we can just use an enum for this. Thanks @errose28 for providing your real time large sized cluster based computation on memory foot print. I agree with your explanation. We can work with enum itself rather short value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
