devmadhuu commented on PR #9472: URL: https://github.com/apache/ozone/pull/9472#issuecomment-3717389314
@errose28 @sodonnel , I have removed short byte value and now using enum, pushed the code. Also current PR is having sampling present to provide only first 100 unhealthy containers, but in future PRs, we can remove sampling considering not much impact on memory as we saw with above computation analysis. so that in future , below CLI can provide any specific unhealthy state containers with some limit option, something like below: `ozone admin container report --health-state UNDER_REPLICATED --limit 100` Because with every RM run, we are updating the state in ContainerInfo also in this PR, so not sure if need both. Based on your input if we need to keep sampling , I need to do code changes in this PR : #9258 to keep consistency of container health data in sync with SCM report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
