szetszwo commented on code in PR #9552:
URL: https://github.com/apache/ozone/pull/9552#discussion_r2651756863
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBBatchOperation.java:
##########
@@ -166,21 +167,30 @@ public void close() {
* Delete operation to be applied to a {@link ColumnFamily} batch.
*/
private static final class DeleteOp extends Op {
- private final byte[] key;
+ private final CodecBuffer key;
Review Comment:
DeleteOp.key is the same as Op.keyBytes. We should move DeleteOp.key to Op,
instead of adding it for all the subclasses. (Since there were byte[] and
CodecBuffer, I did not mention this previously.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBBatchOperation.java:
##########
@@ -166,21 +167,30 @@ public void close() {
* Delete operation to be applied to a {@link ColumnFamily} batch.
*/
private static final class DeleteOp extends Op {
- private final byte[] key;
+ private final CodecBuffer key;
+ private final AtomicBoolean closed = new AtomicBoolean(false);
Review Comment:
Similar to key, we should move this to Op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
