swamirishi commented on code in PR #9552:
URL: https://github.com/apache/ozone/pull/9552#discussion_r2652616988
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBBatchOperation.java:
##########
@@ -166,21 +167,30 @@ public void close() {
* Delete operation to be applied to a {@link ColumnFamily} batch.
*/
private static final class DeleteOp extends Op {
- private final byte[] key;
+ private final CodecBuffer key;
+ private final AtomicBoolean closed = new AtomicBoolean(false);
Review Comment:
DeleteRange doesn't have a ByteBuffer API yet. We would still have to depend
on the byte array. That is why I don't like the idea of bringing in the
codecBuffer Key into Op class
I have raised one
https://github.com/facebook/rocksdb/pull/14197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
