ivandika3 commented on PR #9294: URL: https://github.com/apache/ozone/pull/9294#issuecomment-3697995455
> I also tried making O3SException an unchecked exception, and so far everything looks good — all tests passed without requiring additional catch logic. ([CI](https://github.com/hevinhsu/ozone/actions/runs/20565921336)) From an implementation-simplicity perspective, this option seems quite attractive, and I think it’s worth considering. @hevinhsu Let's go with unchecked exception route. Making `OS3Exception` unchecked should not affect the current exception processing since most `OS3Exception` that are caught are rethrown and `RuntimeException` extends `Exception` so if there are some `Exception` that are caught (e.g. to record audit logs), `RuntimeException` will be caught as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
