hevinhsu commented on PR #9294: URL: https://github.com/apache/ozone/pull/9294#issuecomment-3684735974
Hi @ivandika3, I’ve updated this PR based on your feedback. Separately, I also experimented with making `O3SException` extend `IOException`, so it can be thrown directly from `preCommit`. Initially, this change caused some tests to fail, because there are existing error-handling paths that broadly catch `IOException`, for example: https://github.com/apache/ozone/blob/41dd1509c76ff0a16fe6bda00fdce16cea217996/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java#L508 After adding this additional handling logic: https://github.com/hevinhsu/ozone/blob/3d749523500d076ec9f794eb8f57697eabefb62c/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java#L509-L511 the tests passed again.([CI](https://github.com/hevinhsu/ozone/actions/runs/20434086993)) Due to this behavioral impact and the need to adjust existing exception-handling logic, I did not include the `O3SException extends IOException` change in this PR. I think this direction is still possible, but it likely requires a more careful review of the current exception-handling paths before proceeding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
