bshashikant commented on pull request #2182:
URL: https://github.com/apache/ozone/pull/2182#issuecomment-844754182
@JacksonYao287 , thanks for the explanation.
`public List<GeneratedMessage> getReports(InetSocketAddress endpoint,
int maxLimit) {
if (maxLimit < 0) {
throw new IllegalArgumentException("Illegal maxLimit value: " +
maxLimit);
}
List<GeneratedMessage> reports = getNonIncrementalReports(endpoint);
if (maxLimit <= reports.size()) {
return reports.subList(0, maxLimit);
} else {
reports.addAll(getIncrementalReports(endpoint,
maxLimit - reports.size()));
return reports;
}
}`
The code here suggests, it still tries to send the entire report if it less
than the configured max limit otherwise will send the incremental report. This
will be sent in each HearBeatEndPointTask. Is my understanding correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
