JacksonYao287 commented on pull request #2182:
URL: https://github.com/apache/ozone/pull/2182#issuecomment-845095709
Thanks @bshashikant !
> The code here suggests, it still tries to send the entire report if it
less than the configured max limit otherwise will send the incremental report.
This will be sent in each HearBeatEndPointTask. Is my understanding correct?
```
public List<GeneratedMessage> getAllAvailableReports(
InetSocketAddress endpoint) {
return getReports(endpoint, Integer.MAX_VALUE);
}
```
for now, the code above is the only place where `StateContext#getReports` is
called, and thus `maxLimit` will always be `Integer.MAX_VALUE`. So actually
,`maxLimit` here does not take any effect and fullReport will always be sent in
every heartBeatEndpointTask.
by the way , i think we should not limit the total size of a heartbeat
report . What we should do is just making sure that the datanode always sends
what it should send , which is controlled by the parameters in the
configuration file.
@avijayanhwx PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
