szetszwo commented on code in PR #9608:
URL: https://github.com/apache/ozone/pull/9608#discussion_r2676867527
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -1405,7 +1405,6 @@ static class NonWritableNodeFilter implements
Predicate<DatanodeInfo> {
private final long blockSize;
private final long minRatisVolumeSizeBytes;
private final long containerSize;
Review Comment:
@ptlrs , thanks for reviewing this!
There are final fields such as numPipelinesPerMetadataVolume in
SCMNodeManager. It is consistent to make NonWritableNodeFilter final.
For reconf, SCM currently only supports reconf admins; see below. So, the
filter cannot be modified dynamically.
https://github.com/apache/ozone/blob/cbea8af57461aeb09389237afd1238e65fb93c68/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L401-L407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
