ptlrs commented on code in PR #9608:
URL: https://github.com/apache/ozone/pull/9608#discussion_r2674111784
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -1405,7 +1405,6 @@ static class NonWritableNodeFilter implements
Predicate<DatanodeInfo> {
private final long blockSize;
private final long minRatisVolumeSizeBytes;
private final long containerSize;
Review Comment:
In this PR we are now using a final filter instead of instantiating a new
one.
Will the Ozone configurations mapping to these properties ever be modified
dynamically?
If so, the instantiated filter won't get the updated values for these
configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
