len548 commented on code in PR #9343:
URL: https://github.com/apache/ozone/pull/9343#discussion_r2687331783
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -2022,6 +2022,50 @@
will be used for http authentication.
</description>
</property>
+
+ <property>
+ <name>ozone.s3g.sts.http.enabled</name>
+ <value>false</value>
+ <tag>OZONE, S3GATEWAY</tag>
+ <description>
+ The boolean which enables the Ozone S3Gateway STS endpoint.
+ </description>
+ </property>
+ <property>
+ <name>ozone.s3g.sts.http-bind-host</name>
+ <value>0.0.0.0</value>
+ <tag>OZONE, S3GATEWAY</tag>
+ <description>
+ The bind host for the S3 Gateway STS HTTP server.
+ If not set, the value of ozone.s3g.http-bind-host is used.
+ </description>
+ </property>
+ <property>
+ <name>ozone.s3g.sts.http-address</name>
+ <value>0.0.0.0:9880</value>
+ <tag>OZONE, S3GATEWAY</tag>
+ <description>
+ The HTTP address for the S3 Gateway STS endpoint.
+ </description>
+ </property>
+ <property>
+ <name>ozone.s3g.sts.https-bind-host</name>
+ <value>0.0.0.0</value>
+ <tag>OZONE, S3GATEWAY</tag>
+ <description>
+ The bind host for the S3 Gateway STS HTTPS server.
+ If not set, the value of ozone.s3g.https-bind-host is used.
Review Comment:
Updated.
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3sts/S3STSEnabledEndpointRequestFilter.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.s3sts;
+
+import static
org.apache.hadoop.ozone.s3sts.S3STSConfigKeys.OZONE_S3G_STS_HTTP_ENABLED_KEY;
+
+import java.io.IOException;
+import javax.inject.Inject;
+import javax.ws.rs.container.ContainerRequestContext;
+import javax.ws.rs.container.ContainerRequestFilter;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.Response;
+import javax.ws.rs.ext.Provider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+
+/**
+ * Filter that disables all endpoints annotated with {@link S3STSEnabled}.
+ * Condition is based on the value of the configuration key
+ * ozone.s3g.s3sts.http.enabled.
+ */
+@S3STSEnabled
+@Provider
+public class S3STSEnabledEndpointRequestFilter implements
ContainerRequestFilter {
+ @Inject
+ private OzoneConfiguration ozoneConfiguration;
+
+ @Override
+ public void filter(ContainerRequestContext requestContext) throws
IOException {
+ boolean isSTSEnabled = ozoneConfiguration.getBoolean(
+ OZONE_S3G_STS_HTTP_ENABLED_KEY, false);
+ if (!isSTSEnabled) {
+ String errorMessage = "S3 STS endpoint is disabled.";
+ String errorCode = "NotImplemented";
+ String xmlError = "<ErrorResponse
xmlns=\"https://sts.amazonaws.com/doc/2011-06-15/\";>" +
+ "<Error>" +
+ "<Type>Sender</Type>" +
+ "<Code>" + errorCode + "</Code>" +
+ "<Message>" + errorMessage + "</Message>" +
Review Comment:
I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
