fapifta commented on PR #9343: URL: https://github.com/apache/ozone/pull/9343#issuecomment-3746848112
Based on what we have discussed with @len548 and @fmorg-git I think we are good to go and we can commit this PR. I reviewed the code and I am +1 to commit it. Two things are remaining here, one is to add audit logging, for which I will create a new JIRA and we already agreed with @len548 that he will take it on and finish that part. The minimum and maximum values that are addressed by @Tejaskriya we think they should not be configurable, as the AWS spec is pretty concrete and it defines these as non-configurable boundaries with a non-configurable default value, so we are safe to mimic that and we don't see the use of configurability for those values. @Tejaskriya let me know if you disagree but as this is something you mention as a possibility I assume we are good to go this way. The unification of these constants is to be done by @fmorg-git as part of the integration taks that integrates this endpoint with the OM itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
