[
https://issues.apache.org/jira/browse/HDDS-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-14432:
----------------------------------
Labels: pull-request-available (was: )
> SnapshotDeletingService incorrectly checks Ratis Buffer Limit
> -------------------------------------------------------------
>
> Key: HDDS-14432
> URL: https://issues.apache.org/jira/browse/HDDS-14432
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Aswin Shakil
> Assignee: Aswin Shakil
> Priority: Major
> Labels: pull-request-available
>
> _SnapshotDeletingService_ incorrectly checks the Ratis Buffer Limit when we
> invoke _submitSnapshotMoveDeletedKeys_ , it adds all the keys to the builder
> and then checks the size of the message. Later, it again adds more
> deletedKeys, deletedDirs and renamedKeys on it, The message size is already
> over the ratis buffer limit, instead of creating a new builder we re-use the
> same builder. Ideally we should stop iterating through the snapshot-related
> tables when we hit the buffer limit even before going to
> _submitSnapshotMoveDeletedKeys_
> [https://github.com/apache/ozone/blob/5d4150c460700d73a3915c796dd1766cfaa8912e/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java#L258-L275]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
