bharatviswa504 commented on a change in pull request #2257:
URL: https://github.com/apache/ozone/pull/2257#discussion_r638015520
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -1158,6 +1158,8 @@ public String getDatanodeRpcPort() {
*/
@Override
public void start() throws IOException {
+ upgradeFinalizer.runPrefinalizeStateActions(scmStorageConfig, this);
Review comment:
Just a question why do we need to delay this check until the start? Why
can't it be done in the StorageManager constructor for fail fast?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
