bharatviswa504 commented on a change in pull request #2257:
URL: https://github.com/apache/ozone/pull/2257#discussion_r635098004



##########
File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -1158,6 +1158,8 @@ public String getDatanodeRpcPort() {
    */
   @Override
   public void start() throws IOException {
+    upgradeFinalizer.runPrefinalizeStateActions(scmStorageConfig, this);

Review comment:
       Yes, but if init happens again after we upgrade bits with ha enable flag 
(after upgrade), then this will not catch the issue right? As on an upgraded 
cluster, init can happen, check else block of scmInit.
   Like in some deployments where init is run with every restart.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to