ChenSammi commented on code in PR #9363:
URL: https://github.com/apache/ozone/pull/9363#discussion_r2744522667
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -917,6 +917,68 @@ message SnapshotDiffJobProto {
optional double keysProcessedPct = 13;
}
+/**
+ * Per request type entities to hold arguments
+ * captured for CompletedRequestInfo
+ */
+message CreateVolumeOperationArgs {
+}
+
+message DeleteVolumeOperationArgs {
+}
+
+message CreateBucketOperationArgs {
+}
+
+message DeleteBucketOperationArgs {
+}
+
+message CreateKeyOperationArgs {
+}
+
+message RenameKeyOperationArgs {
+ required string toKeyName = 1;
+}
+
+message DeleteKeyOperationArgs {
+}
+
+message CommitKeyOperationArgs {
+}
+
+message CreateDirectoryOperationArgs {
+}
+
+message CreateFileOperationArgs {
+ required bool isRecursive = 2;
+ required bool isOverwrite = 3;
+}
+
+
+/**
+ * CompletedRequestInfo table entry
+ */
+message CompletedRequestInfo {
+
+ optional int64 trxLogIndex = 1;
Review Comment:
I guess I know the difference between proto2 and proto3. If we really have
spent time on code review, it will be easy to found that CompletedRequestInfo
has both optional and required fields, so does the other new proto definition
introduced. So we either straightforwardly comply with proto2 since
OmClientProtocol.proto is proto2, or we follow the proto3 behavior,
consistently using optional fields with a clear comment that proto3 behavior is
used since it's proto2 definition, make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
