errose28 commented on PR #9640: URL: https://github.com/apache/ozone/pull/9640#issuecomment-3824336789
Thanks for working on this @adoroszlai. Can we fully switch to using `maven.compiler.release` instead of `javac.version` as described in HDDS-13670 as part of this PR? Here we are adding another java version field without removing the old one that was already redundant. Also should the default build behavior for the client be to inherit the version from the JDK being used, or should it default to 8 and require passing `maven.compiler.release` if a different bytecode version is required? I think since we are setting a server side default we should probably explicitly set a client side default as well for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
