adoroszlai commented on PR #9640: URL: https://github.com/apache/ozone/pull/9640#issuecomment-3825106011
> Can we fully switch to using `maven.compiler.release` instead of `javac.version` as described in [HDDS-13670](https://issues.apache.org/jira/browse/HDDS-13670) Created separate PR #9693. > Also should the default build behavior for the client be to inherit the version from the JDK being used, That wouldn't work: to get client jars for JDK 8, we'd need to build with JDK 8, but server-side part requires JDK >= 17. > we should probably explicitly set a client side default as well for consistency Now we have two sets of modules, "server" (explicitly have `maven.compiler.release` set) and "other" (inherits from root POM). If we did have `maven.compiler.release` in all modules (server or client), consider the case where a new module is being added but the author forgets to set the property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
