echonesis commented on PR #9689: URL: https://github.com/apache/ozone/pull/9689#issuecomment-3838665726
> @echonesis , thanks a lot for working on this! > > Both the ratisStorageDir and ratisSnapshotDir should only be created only if either --init or --bootstrap option is set in StorageContainerManagerStarter. Without those options, the directories should already exist. If not, we should fail the command. > > Please see also the comments inlined. Thanks @szetszwo I agree with this principle. However, there's an **upgrade scenario** I'd like to clarify: In `StorageContainerManager` constructor ([L376-378](https://github.com/echonesis/ozone/blob/ed1b910a482b3544644327fb26883a1fca8d2ad8/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java#L376-L378)), when an old cluster (without Ratis/HA) starts normally and detects `!isSCMHAEnabled()`, it calls `initializeRatis()` to auto-enable Ratis. This also needs to create the directories. Should this upgrade path: 1. Continue to auto-create directories (current behavior), or 2. Require users to run `--init` first before upgrading? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
