echonesis commented on code in PR #9689:
URL: https://github.com/apache/ozone/pull/9689#discussion_r2756899826
##########
hadoop-ozone/dist/src/main/smoketest/repair/om-compact.robot:
##########
@@ -36,19 +36,20 @@ Compact OM DB Column Family
[Arguments] ${column_family}
Execute ozone repair om compact --cf=${column_family} --service-id
${OM_SERVICE_ID} --node-id om1
+SST Size Should Be Reduced
+ [Arguments] ${original_size}
+ ${current_size} = Get OM DB SST Files Size
+ Should Be True ${current_size} < ${original_size}
+ ... OM DB size should be reduced after compaction. Before:
${original_size}, After: ${current_size}
+
*** Test Cases ***
Testing OM DB Size Reduction After Compaction
- # Test keys are already created and flushed
- # Delete keys to create tombstones that need compaction
- Delete Test Keys
-
+ # Test keys are already created, deleted and flushed by the test script
${size_before_compaction} = Get OM DB SST Files Size
Compact OM DB Column Family fileTable
Compact OM DB Column Family deletedTable
Compact OM DB Column Family deletedDirectoryTable
-
- ${size_after_compaction} = Get OM DB SST Files Size
- Should Be True ${size_after_compaction} < ${size_before_compaction}
- ... OM DB size should be reduced after compaction. Before:
${size_before_compaction}, After: ${size_after_compaction}
+ # Compaction is asynchronous, poll until size is reduced
+ Wait Until Keyword Succeeds 60sec 5sec SST Size Should Be Reduced
${size_before_compaction}
Review Comment:
Same as https://github.com/apache/ozone/pull/9689#discussion_r2756895905
This ensures proper ordering after container restarts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
