Russole commented on code in PR #9710:
URL: https://github.com/apache/ozone/pull/9710#discussion_r2776644413
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -1102,6 +1102,9 @@ private Response listParts(OzoneBucket ozoneBucket,
String key, String uploadID,
bucketName + "/" + key + "/" + uploadID, ex);
}
throw ex;
+ } catch (IOException | RuntimeException ex) {
+ getMetrics().updateListPartsFailureStats(startNanos);
+ throw ex;
Review Comment:
Thanks @Gargi-jais11 for pointing this out.
I’ve updated `listParts()` to handle updating `listPartsFailureStats` itself
for both `OMException` and other `IOException / RuntimeException` cases.
This keeps the responsibilities clearly separated: `listParts()` is
responsible for list-parts metrics, while the outer handler only updates
`GetKey-related` metrics.
This avoids double-counting while still ensuring all list-parts failures are
recorded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
