sreejasahithi commented on code in PR #9735:
URL: https://github.com/apache/ozone/pull/9735#discussion_r2783502683
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java:
##########
@@ -221,6 +221,8 @@ public final class ScmConfigKeys {
public static final int OZONE_SCM_HTTP_BIND_PORT_DEFAULT = 9876;
public static final int OZONE_SCM_HTTPS_BIND_PORT_DEFAULT = 9877;
public static final String HDDS_DATANODE_DIR_KEY = "hdds.datanode.dir";
+ public static final String HDDS_DATANODE_DATA_DIR_PERMISSIONS =
+ "hdds.datanode.data.dir.permissions";
Review Comment:
```suggestion
"hdds.datanode.data.dir.permissions";
public static final String HDDS_DATANODE_DATA_DIR_PERMISSIONS_DEFAULT
= "700";
```
I think it would be better to add the default value as well to be consistent
with other configs here. Or we could avoid it as other permission configs don't
mention the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
