priyeshkaratha commented on code in PR #9743:
URL: https://github.com/apache/ozone/pull/9743#discussion_r2797098597
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/overview/overview.tsx:
##########
@@ -238,50 +200,59 @@ const Overview: React.FC<{}> = () => {
lg: 16,
xl: 16
}, 20]}>
- <Col xs={24} sm={24} md={24} lg={10} xl={10}>
- <OverviewSummaryCard
- title='Health'
- data={healthCardIndicators}
- showHeader={true}
+ <Col xs={24} sm={24} md={24} lg={12} xl={12}>
+ <OverviewHealthCard
+ title='Datanodes'
loading={clusterState.loading}
- columns={[
- {
- title: '',
- dataIndex: 'name',
- key: 'name'
- },
- {
- title: 'Available',
- dataIndex: 'value',
- key: 'value',
- align: 'right'
- },
- {
- title: 'Actions',
- dataIndex: 'action',
- key: 'action',
- align: 'right'
- }
- ]}
- tableData={[
- {
- key: 'datanodes',
- name: 'Datanodes',
- value: `${healthyDatanodes}/${totalDatanodes}`,
- action: datanodesLink
- },
- {
- key: 'containers',
- name: 'Containers',
- value: `${containers - missingContainers}/${containers}`,
- action: containersLink
- }
- ]}
+ available={healthyDatanodes ?? 'N/A'}
Review Comment:
can you tell me the scenarios where healthyDatanodes is null or undefined?
Is this added to handle any specific scenarios or just to handle unknown
exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
